-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SPDX for licenses #2122
Use SPDX for licenses #2122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Perfect.
Codecov Report
@@ Coverage Diff @@
## main #2122 +/- ##
=======================================
Coverage 63.98% 63.98%
=======================================
Files 97 97
Lines 19084 19084
Branches 9750 9750
=======================================
Hits 12211 12211
Misses 4599 4599
Partials 2274 2274
Continue to review full report at Codecov.
|
539e513
to
3be66bf
Compare
3be66bf
to
65e8f6b
Compare
Thanks! I would like to kindly ask you to re-approve. I had to amend the last commit to fix the compilation in one of the CI jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muchas gracias.
As it has been discussed recently in the team chat, I am proposing here the usage of the SPDX standard for the definition of the project licenses: https://spdx.dev/ . It seems to be the way to go for specifying the license in open source projects and many projects are already using it (between them the Linux kernel).
I am proposing this change because I found a bit irritating to have such duplication in the comments for each file. Furthermore, the years appearing in the copyright were different in each of the modified files.